Skip to content

Update plotly.js version to 1.47.1 in plotly mimetype renderer #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

jonmmease
Copy link

@jonmmease jonmmease commented Apr 23, 2019

Closes https://github.com/Microsoft/vscode-python/issues/4953

  • Update @nteract/transform-plotly to 5.0.0
  • Add @nteract/plotly dependency to directly control minimum plotly.js version. Updates to plotly.js 1.47.1.

With these changes, recent plotly.js features, like themes, are now supported in VSCode 🎉

Screenshot_20190423_065531

I can add a news entry if you'd like. I wasn't sure if you include dependency updates in the release notes.


  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

Add @nteract/plotly dep to directly control minimum plotly.js version
@msftclas
Copy link

msftclas commented Apr 23, 2019

CLA assistant check
All CLA requirements met.

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News entry not necessary.

Thanks a bunch.

@rchiodo rchiodo merged commit 8fb8107 into microsoft:master Apr 23, 2019
@jonmmease jonmmease deleted the plotly_1.47.1 branch April 24, 2019 09:34
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the plotly.js version used in the plotly mimetype renderer
3 participants