Skip to content

Ensure that workspaceFolder field in API points to workspace folder when available. #20107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ensure that workspaceFolder field in API points to workspace folder when available. #20107

wants to merge 1 commit into from

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 28, 2022

Fixes #20105

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Oct 28, 2022
@karthiknadig karthiknadig self-assigned this Oct 28, 2022
@karthiknadig karthiknadig requested a review from karrtikr October 28, 2022 06:00
@karthiknadig karthiknadig added the skip tests Updates to tests unnecessary label Oct 28, 2022
@karthiknadig karthiknadig marked this pull request as ready for review October 28, 2022 06:14
@karthiknadig karthiknadig mentioned this pull request Oct 28, 2022
Merged
@karrtikr
Copy link

karrtikr commented Oct 28, 2022

Closing in favor of #20108 where we also change the type from Uri to WorkspaceFolder to better indicate the fact that these environments only belong to the currently opened workspace folders.

@karrtikr karrtikr closed this Oct 28, 2022
@karthiknadig karthiknadig deleted the venv-location branch November 2, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karrtikr karrtikr Awaiting requested review from karrtikr

Assignees

@karthiknadig karthiknadig

Labels

bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WorkspaceFolder value in resolved environment is incorrect

2 participants

@karthiknadig @karrtikr