Skip to content

Port run by line stepping fix to release #12223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Port run by line stepping fix to release #12223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cacf9b
fix continue event to run cell (#12211)
IanMatthewHuff Jun 9, 2020
566e19c
update changelog and delete news file
Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@
([#12169](https://github.com/Microsoft/vscode-python/issues/12169))
1. Disable `Sort Imports` command in `Notebook Cells`.
([#12193](https://github.com/Microsoft/vscode-python/issues/12193))
1. Fix debugger continue event to actually change a cell.
([#12155](https://github.com/Microsoft/vscode-python/issues/12155))

### Code Health

Expand Down
6 changes: 3 additions & 3 deletions src/client/datascience/interactive-ipynb/nativeEditorRunByLineListener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,18 @@ export class NativeEditorRunByLineListener

private async handleStep() {
// User issued a step command.
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
return this.debugService.step();
}

private async handleContinue() {
// User issued a continue command
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
return this.debugService.continue();
}

private async handleContinueEvent() {
// Tell the ui to erase the current IP
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
}
}