Skip to content

Changed property name used to capture the trigger source of Unit Tests. #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Changed property name used to capture the trigger source of Unit Tests. #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/3 Code Health/1213.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Changed property name used to capture the trigger source of Unit Tests.
2 changes: 1 addition & 1 deletion src/client/telemetry/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export type TestRunTelemetry = {
tool: 'nosetest' | 'pytest' | 'unittest';
scope: 'currentFile' | 'all' | 'file' | 'class' | 'function' | 'failed';
debugging: boolean;
trigger: 'ui' | 'codelens' | 'commandpalette' | 'auto';
triggeredBy: 'ui' | 'codelens' | 'commandpalette' | 'auto';
failed: boolean;
};
export type TestDiscoverytTelemetry = {
Expand Down
2 changes: 1 addition & 1 deletion src/client/unittests/common/managers/baseTestManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export abstract class BaseTestManager implements ITestManager {
tool: this.testProvider,
scope: 'all',
debugging: debug === true,
trigger: cmdSource,
triggeredBy: cmdSource,
failed: false
};
if (runFailedTests === true) {
Expand Down