Skip to content

Conversation

@karthiknadig
Copy link
Member

No description provided.

kimadeline and others added 9 commits May 7, 2020 08:05
…11602) (microsoft#11656)

* Revert "Fix slashes in telemetry unit tests (microsoft#11572)"

This reverts commit 7431c9c.

* Revert "Use vscode-extension-telemetry for our exceptions & error telemetry (microsoft#11524)"

This reverts commit d5065e6.

* Remove from changelog
* Fix storage not being used (microsoft#11649)

* Fix storage not being used

* Add disposable to storage so it won't write after shutdown

* Fix dirty title

* Hack to get tests to pass

* Another way to get run all to not interfere

* Update changelog
* Fix scrolling (microsoft#11681)

* Fix scrolling

* Review feedback - fix scrolling on expand/collapse

* Update changelog

* Update package.json

Co-authored-by: Jim Griesmer <[email protected]>
…icrosoft#11700)

* Show the prompt again if user clicks on more info (microsoft#11664)

* Show the prompt again if user clicks on more info

* Review feedback

* Use Learn more as text for the link.

* Leave pipenv in a corner until the user decides to select an interpreter (microsoft#11654)

* add onSuggestion option
* Swap onActivation with onSuggestion
* Update unit tests
* Remove registration of IPipenvService
* Move didTriggerInterpreterSuggestions logic inside pipenv locator
* Fix existing unit tests
* Add new unit tests
* Replace typemoq any param with object
* Shorten the tests
* Fix warning
* Duplicate teardown

Co-authored-by: Kim-Adeline Miguel <[email protected]>
* Update extension version

* Update date in changelog.
* Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang (microsoft#11816)

* Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang

* Rename

* Oops

* Update src/test/providers/shebangCodeLenseProvider.unit.test.ts

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Update version and change log for bugfix release

Co-authored-by: Kartik Raj <[email protected]>
@karthiknadig karthiknadig added the no-changelog No news entry required label May 19, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't a ghost, I reran the pipeline for the PR while I was here 🔧

@karthiknadig karthiknadig merged commit 27b774e into microsoft:master May 19, 2020
@karthiknadig karthiknadig deleted the mergeback1 branch June 9, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants