Update to use latest python environment APIs #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I may still need to provide backwards compatibility so this template works with the older versions of the extension. EDIT: Upgraded VSCode engine instead. |
Member
|
You may have to rebase this. But this is good. I will approve after rebase. |
karrtikr
force-pushed
the
updatePythonAPI
branch
from
64ce4f8 to
4347f58
Compare
Contributor
Author
|
@karthiknadig Done. Please approve microsoft/vscode-python#19944 again as well. |
karthiknadig
approved these changes
Oct 4, 2022
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good to go once we make sure microsoft/vscode-python#19938 goes into our latest release.