Skip to content

Improve ProjectCommand.getMainClasses #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2025
Merged

Improve ProjectCommand.getMainClasses #883

merged 3 commits into from
Aug 11, 2025

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Jul 20, 2025

Fixes #882

@wenytang-ms wenytang-ms requested a review from jdneo August 7, 2025 03:26
@wenytang-ms
Copy link
Contributor

wenytang-ms commented Aug 11, 2025 •
edited
Loading

the public void main() is the preview feature from JDK 21+
https://www.oracle.com/java/technologies/javase/21-relnote-issues.html

@snjeza
Copy link
Contributor Author

snjeza commented Aug 11, 2025

@wenytang-ms You may want to take a look at https://github.com/microsoft/java-debug/blob/a1f68f4265458e9386bf16d107c2383b68690e43/com.microsoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/ResolveMainClassHandler.java#L215

@wenytang-ms
Copy link
Contributor

@wenytang-ms You may want to take a look at https://github.com/microsoft/java-debug/blob/a1f68f4265458e9386bf16d107c2383b68690e43/com.microsoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/ResolveMainClassHandler.java#L215

yes, I see

@wenytang-ms wenytang-ms merged commit afdf59d into microsoft:main Aug 11, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenytang-ms wenytang-ms wenytang-ms approved these changes

@jdneo jdneo Awaiting requested review from jdneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ProjectCommand.getMainClasses
2 participants
@snjeza @wenytang-ms