This repository was archived by the owner on Nov 30, 2023. It is now read-only.
Tensorflow devcontainer #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@bhack Let me know when you think this is to the point it should be reviewed. I assume you're still making edits like you had for the tenserflow_addons PR. |
|
No this is totally independent cause it is not waiting for a upstream image. We are wrapping on the official one. So if you want you can make a pass. I suppose that pylint is enabled by default right? |
Chuxel
approved these changes
Jun 24, 2020
repository-containers/github.com/tensorflow/tensorflow/.devcontainer/devcontainer.json
Outdated
Show resolved
Hide resolved
|
@Chuxel If you can try it on GPU we could merge. |
|
Unfortunately, I don't have a Linux machine with a NVIDIA GPU in it. (My Linux laptop has an Intel GPU.) My Azure VMs aren't using GPU SKUs at the moment either unfortunately. |
|
Ok let's merge we will see if somebody with GPU will open a ticket. |
This was referenced Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Tensorflow devcontainer