Skip to content

Conversation

@jakebailey
Copy link
Member

Meant to do this when copying stuff over from the main repo.

Uses the config from microsoft/TypeScript#60828 but ignoring the TS submodule and all testdata files.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jakebailey
Copy link
Member Author

Quite a few things caught by CodeQL above, all to do with conversions in the evaluator where I actually think they're not "wrong" given JS's own truncation, but may mean we need to include some sort of explicit truncation or rounding to be clear about what we're doing for these JS evaluations.

@jakebailey
Copy link
Member Author

All of the flagged stuff is valid, but mainly because it's showing that our handling of JS integers is wrong; I'll come up with a different PR with some tests which can better handle this.

@jakebailey
Copy link
Member Author

With the new jsnum package, there's only one conversion complaint (the fast path), which I have silenced as it's intentional and its result is checked.

@jakebailey jakebailey merged commit 2013d07 into main Jan 8, 2025
14 checks passed
@jakebailey jakebailey deleted the jabaile/codeql branch January 8, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants