Multiproject requests like find all refs, rename and workspace symbols #1991
+22,109
−907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
force-pushed
the
multiProject
branch
5 times, most recently
from
46a8abe to
f66df9c
Compare
Also remove unnecessary program update when doing gc on projects
… with -v so we can diagnose which test is failing
sheetalkamat
force-pushed
the
multiProject
branch
from
97ecb11 to
72e09da
Compare
sheetalkamat
commented
Nov 4, 2025
Member
Author
|
converting tests to fourslash uncovered some more ordering issues with results. Looking into that as well as handling the feedback |
andrewbranch
approved these changes
Nov 14, 2025
Member
andrewbranch
left a comment
andrewbranch
left a comment
There was a problem hiding this comment.
All my concerns are addressed, hopefully someone else can review as well 👍
Member
|
I'll give it another pass shortly, though I was waiting until it was mostly passing CI. |
jakebailey
reviewed
Nov 14, 2025
Member
Author
I am still looking into deduplicating results as there is still something going on there. |
… and load their tree
Member
Author
Have resolved this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.