Skip to content

Conversation

jakebailey
Copy link
Member

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports TypeScript PR 61805 to address changes related to the module=node20 configuration, focusing on updates to module resolution behavior and module format handling in Node.js 20 environments.

Key changes include:

  • Removal of legacy module resolution validation errors
  • Updated module output formats for ESM vs CJS contexts
  • Improved import assertion to import attributes error messaging
  • Corrected module resolution strategy selection

Reviewed Changes

Copilot reviewed 300 out of 645 changed files in this pull request and generated no comments.

File Description
Multiple baseline error files Removed TS5109 errors requiring Node16 module resolution with Node20 module setting
Multiple baseline JavaScript output files Updated module compilation output to use proper ESM syntax instead of CommonJS when appropriate
Import assertion baseline files Changed error messages from import assertions to import attributes deprecation warnings
Module resolution trace files Updated to show Node16 resolution strategy instead of Bundler

@jakebailey
Copy link
Member Author

Hm, data race...

@jakebailey
Copy link
Member Author

I can't figure out how to deal with the circularity errors when compiling concurrently. These are the kinds of errors that we have been silencing by skipping the tests (concurrentSkippedErrorBaselines), which would defeat the purpose of these checks. I am not sure if this means the tests are "bad" themselves for introducing those circularities, or if there's a bug in my (or someone else's) ported code that's causing the issue.

@jakebailey
Copy link
Member Author

The symbol baselines doing something like:

image

Implies that we are somehow choosing the wrong import when compiling concurrently, so I hope it's just that kind of bug, but the race detector does not detect anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant