-
Notifications
You must be signed in to change notification settings - Fork 709
Port PR 61805 - module=node20 #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ports TypeScript PR 61805 to address changes related to the module=node20
configuration, focusing on updates to module resolution behavior and module format handling in Node.js 20 environments.
Key changes include:
- Removal of legacy module resolution validation errors
- Updated module output formats for ESM vs CJS contexts
- Improved import assertion to import attributes error messaging
- Corrected module resolution strategy selection
Reviewed Changes
Copilot reviewed 300 out of 645 changed files in this pull request and generated no comments.
File | Description |
---|---|
Multiple baseline error files | Removed TS5109 errors requiring Node16 module resolution with Node20 module setting |
Multiple baseline JavaScript output files | Updated module compilation output to use proper ESM syntax instead of CommonJS when appropriate |
Import assertion baseline files | Changed error messages from import assertions to import attributes deprecation warnings |
Module resolution trace files | Updated to show Node16 resolution strategy instead of Bundler |
Hm, data race... |
I can't figure out how to deal with the circularity errors when compiling concurrently. These are the kinds of errors that we have been silencing by skipping the tests ( |
Ports microsoft/TypeScript#61805