Set UseAliasDefinedOutsideCurrentScope in hover #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
requested review from
DanielRosenwasser,
andrewbranch,
Copilot and
gabritto
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TypeScript hover functionality to improve type display by setting the UseAliasDefinedOutsideCurrentScope flag for type formatting. This change ensures that type aliases defined outside the current scope are properly displayed in hover information, preventing the display of random import nodes that were confusing users.
Key Changes
- Updates
typeFormatFlagsto includeUseAliasDefinedOutsideCurrentScopeflag for better type alias resolution in hover displays
Comments suppressed due to low confidence (1)
internal/ls/hover.go:18
- This change to type formatting flags lacks test coverage. Consider adding a fourslash test that verifies hover behavior with type aliases defined outside the current scope to ensure this flag works as expected.
typeFormatFlags = checker.TypeFormatFlagsUseAliasDefinedOutsideCurrentScope
Member
|
I'm guessing we have tests that are not ported (non-baseline ones). In the meantime, can you add a non-generated test which previously exhibits the behavior? I feel like that should be pretty easy to repro. |
jakebailey
force-pushed
the
jabaile/hover-type-format-flags
branch
from
9880a6a to
752e2f5
Compare
Member
Author
|
Rebased with a test that shows the difference. |
DanielRosenwasser
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Confusingly, no existing fourslash test seems to test this? I was seeing it all the time.
This one flag is not the extent of the flags hover used to set; it also used to sometimes set
MultilineObjectLiteralsfor type display parts, but doing that regressed the existing tests.MultilineObjectLiterals,WriteTypeArgumentsOfSignature,OmitParameterModifiersused to be set for signature display parts, but it wasn't immediately obvious to me where to set that.Mainly, I just want to stop seeing the random import nodes which Strada does not show.