Add signin/failure invoke activity support #206
Draft
+132
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK was throwing validation errors when receiving
signin/failureinvoke activities because this invoke type was not defined in the activity model discriminated union.Changes
Added
SignInFailuremodel (packages/api/src/microsoft/teams/api/models/sign_in/failure.py)codeandmessagefrom sign-in failuresAdded
SignInFailureInvokeActivity(packages/api/src/microsoft/teams/api/activities/invoke/sign_in/failure.py)signin/failureinvoke typesignin/tokenExchangeandsignin/verifyStateUpdated
SignInInvokeActivitydiscriminated unionSignInFailureInvokeActivityas a valid memberExample
Activities like this from the issue now parse successfully:
{ "name": "signin/failure", "type": "invoke", "value": { "code": "resourcematchfailed", "message": "Resource match failed" }, ... }Before:
union_tag_invalidvalidation errorAfter: Activity parses correctly, error details available to handlers
Original prompt
This section details on the original issue you should resolve
<issue_title>SignIn failures are not handled gracefully.</issue_title>
<issue_description>When there is a sign in failure, the invoke says this. It looks like we're missing a signin/failure invoke type.