Add Federated Identity Credentials support #203
+365
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2025
Open
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
9aea378 to
718bc09
Compare
heyitsaamir
force-pushed
the
aamirj/fic
branch
3 times, most recently
from
a1b11bb to
b222662
Compare
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
b7b879b to
e855432
Compare
heyitsaamir
force-pushed
the
aamirj/fic
branch
from
b222662 to
49c8535
Compare
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
e855432 to
0943c05
Compare
heyitsaamir
force-pushed
the
aamirj/fic
branch
from
49c8535 to
14137e4
Compare
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
0943c05 to
42eddff
Compare
heyitsaamir
force-pushed
the
aamirj/fic
branch
2 times, most recently
from
40c3b31 to
58517da
Compare
heyitsaamir
force-pushed
the
aamirj/fic
branch
from
58517da to
fb334f0
Compare
rido-min
approved these changes
Nov 6, 2025
lilyydu
reviewed
Nov 6, 2025
| def _get_msal_client(self, tenant_id: str) -> ConfidentialClientApplication | ManagedIdentityClient: | ||
| credentials = self._credentials | ||
| def _resolve_tenant_id( | ||
| self, tenant_id: str | None, credentials: ClientCredentials | FederatedIdentityCredentials | TokenCredentials |
There was a problem hiding this comment.
should we define all 3 as another type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Federated Identity Credentials.
Federated Identity Credentials has a two step process. It first uses managed identity (UMI or SI) to get an token-assertion. This then is used to build a ConfidentialClient to get the actual token.
PR Dependency Tree
This tree was auto-generated by Charcoal