Skip to content

Conversation

@MehakBindra
Copy link
Contributor

@MehakBindra MehakBindra commented Oct 29, 2025

  • Added BotBuilderPlugin (overrides http plugin's on_activity_request)
  • Refactored HttpPlugin to easily extend to botbuilder without code duplication
  • Added a test sample
  • Added unit tests
  • Added HttpPluginOptions to be able to extend easily
  • Moved jwt validation initialization to on init in http plugin to leverage DI for credentials
Screenshot 2025-10-28 171527

Copilot AI review requested due to automatic review settings October 29, 2025 00:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new microsoft-teams-botbuilder package to enable backward compatibility with legacy Microsoft Bot Framework bots. The integration allows existing bots built with the BotBuilder SDK to work within the new Microsoft Teams AI Library architecture.

Key Changes

  • Introduces the microsoft-teams-botbuilder package with a plugin that bridges BotBuilder SDK and the Teams Apps framework
  • Adds a test application demonstrating BotBuilder integration with the new framework
  • Refactors the HTTP plugin to expose response handling methods for plugin extensibility

Reviewed Changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
uv.lock Adds dependency lock entries for the new botbuilder package, test application, and required Bot Framework SDK dependencies (botbuilder-core, botbuilder-integration-aiohttp, etc.)
packages/botbuilder/pyproject.toml Defines the new microsoft-teams-botbuilder package with dependencies on Bot Framework SDK and Teams packages
packages/botbuilder/src/microsoft/teams/botbuilder/botbuilder_plugin.py Implements the BotBuilderPlugin that integrates Bot Framework adapters and handlers with the Teams Apps framework
packages/botbuilder/src/microsoft/teams/botbuilder/__init__.py Exports the BotBuilderPlugin and BotBuilderPluginOptions for public API
packages/botbuilder/tests/test_botbuilder_plugin.py Provides comprehensive test coverage for the BotBuilderPlugin functionality
tests/botbuilder/src/main.py Example test application demonstrating BotBuilder and Teams framework integration
tests/botbuilder/pyproject.toml Configuration for the botbuilder test application
packages/apps/src/microsoft/teams/apps/http_plugin.py Refactors response handling into a protected method for extensibility
pyrightconfig.json Adds the new botbuilder package to type checking configuration
pyproject.toml Registers the new package in the workspace
README.md Documents the new package and applies minor formatting fixes

Copy link
Collaborator

@heyitsaamir heyitsaamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Sample could use work! TY!

Copy link
Collaborator

@heyitsaamir heyitsaamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Asking for a comment, and I still don't fully understand the app_id thing. Why do we need it?

@MehakBindra MehakBindra merged commit 9ecfc1b into main Nov 12, 2025
7 checks passed
@MehakBindra MehakBindra deleted the mehak/botbuilder branch November 12, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants