[PY] feat: TeamsAttachmentDownloader #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyydu
requested review from
aacebo,
blackchoey,
corinagum and
singhk97
as code owners
…ft/teams-ai into lilyydu/file-downloaders
aacebo
reviewed
Apr 8, 2024
aacebo
reviewed
Apr 8, 2024
aacebo
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #1331, #1182
Details
TeamsAttachmentDownloader(incl updates toApplication,InputFileclasses)Notes
configurationobject is of type "Any" on the BF side (limitation)stateproperty fromInputFileDownloader(onlycontextis needed)toChannelFromBotLoginUrlconstant - this ensures the check for US Government Azure can resolve as TrueAuthenticResultinterface