Skip to content

[api-extractor] Clarify "reportFileName" semantics #4846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2024
Merged

[api-extractor] Clarify "reportFileName" semantics #4846

merged 3 commits into from
Jul 23, 2024

Conversation

@octogonz
Copy link
Collaborator

@octogonz octogonz commented Jul 22, 2024

Motivated by the discussion from #4842:

  • Clarify the docs for reportFileName
  • Fix an edge case where the code that stripped the file extension would incorrectly match the middle of a string @Josmithr

Impacted documentation

After this is merged, we need to add website docs for the new reportVariants setting (PR #4621)

@octogonz octogonz mentioned this pull request Jul 22, 2024
Open
@octogonz octogonz merged commit 1a92f17 into main Jul 23, 2024
@octogonz octogonz deleted the octogonz/ae-reportfilename-extension branch July 23, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D4N14L D4N14L D4N14L approved these changes

@iclanton iclanton Awaiting requested review from iclanton iclanton is a code owner

@apostolisms apostolisms Awaiting requested review from apostolisms apostolisms is a code owner

@dmichon-msft dmichon-msft Awaiting requested review from dmichon-msft dmichon-msft is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Bug Triage
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@octogonz @D4N14L