[0.73] Lock to [email protected] to prevent using newer broken versions #12586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n versions ## Description When updating dependencies in main, (see microsoft#12575), we found that [email protected] breaks our CLI commands. We aren't actually collecting telemetry so there's no problem with locking the version of this package in this branch for now. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To unblock calls to CLI commands by new projects. ### What Lock to the current version used by this branch. ## Screenshots N/A ## Testing Ran yarn build locally, which calls `codegen-windows` internally. ## Changelog Should this change be included in the release notes: no
Contributor
Author
|
If and when we want to enable telemetry in this branch, we can't upgrade applicationinsights past 2.9.1 unless we can get a version where this PR has been merged: microsoft/ApplicationInsights-node.js#1259 |
marlenecota
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating dependencies in main, (see #12575), we found that [email protected] breaks our CLI commands.
We aren't actually collecting telemetry so there's no problem with locking the version of this package in this branch for now.
Type of Change
Why
To unblock calls to CLI commands by new projects.
What
Lock to the current version used by this branch.
Screenshots
N/A
Testing
Ran yarn build locally, which calls
codegen-windowsinternally.Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow