Skip to content

fix(android): ensure SoLoader is initialized #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

fix(android): ensure SoLoader is initialized #2024

merged 1 commit into from
May 7, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 7, 2024 •
edited
Loading

Description

Ensure SoLoader is initialized otherwise it may crash when New Arch is enabled on 0.71

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version 0.71 -- --core-only
yarn
cd example
yarn android --extra-params "-PnewArchEnabled=true"

# In a separate terminal
yarn start

@tido64 tido64 requested a review from kelset as a code owner May 7, 2024 13:41
@github-actions github-actions bot added the platform: Android This affects Android label May 7, 2024
@tido64 tido64 force-pushed the tido/android-soloader branch from f72f280 to b31d4c7 Compare May 7, 2024 13:46
@tido64 tido64 mentioned this pull request May 7, 2024
Merged
kelset
kelset approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, it works!

@tido64 tido64 merged commit 590f8f8 into trunk May 7, 2024
@tido64 tido64 deleted the tido/android-soloader branch May 7, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@krizzu krizzu krizzu approved these changes

@kelset kelset kelset approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tido64 @krizzu @kelset