Skip to content

fix(android): handle ReactApplication changes to getters #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2023
Merged

fix(android): handle ReactApplication changes to getters #1483

merged 2 commits into from
Jul 4, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jul 4, 2023

Description

Signature changes were introduced in facebook/react-native@c3f672c.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

git apply scripts/disable-safe-area-context.patch
git apply scripts/android-nightly.patch
npm run set-react-version -- nightly
npm run clean
yarn
cd example/android
./gradlew clean assembleDebug

@tido64 tido64 requested a review from kelset July 4, 2023 08:03
@github-actions github-actions bot added the platform: Android This affects Android label Jul 4, 2023
@tido64 tido64 marked this pull request as ready for review July 4, 2023 11:36
@tido64 tido64 merged commit fafd197 into trunk Jul 4, 2023
@tido64 tido64 deleted the tido/android-compatibility branch July 4, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweggersen sweggersen sweggersen approved these changes

@kelset kelset Awaiting requested review from kelset

@arazabishov arazabishov Awaiting requested review from arazabishov

Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @sweggersen