Skip to content

fix(android): fix Fabric cannot be enabled on 0.72 #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2023
Merged

fix(android): fix Fabric cannot be enabled on 0.72 #1389

merged 2 commits into from
Apr 13, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 13, 2023 •
edited
Loading

Description

Fix Fabric cannot be enabled on 0.72

Prerequisite for #1359.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run set-react-version 0.72
yarn
cd example

# Set `newArchEnabled=true` in /example/gradle.properties

yarn android

@tido64 tido64 requested a review from kelset April 13, 2023 09:48
@github-actions github-actions bot added the platform: Android This affects Android label Apr 13, 2023
@tido64 tido64 mentioned this pull request Apr 13, 2023
Closed
8 tasks
@tido64 tido64 enabled auto-merge (squash) April 13, 2023 10:01
@tido64 tido64 merged commit fd1b266 into trunk Apr 13, 2023
@tido64 tido64 deleted the tido/android/venice-compat branch April 13, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arazabishov arazabishov Awaiting requested review from arazabishov

@sweggersen sweggersen Awaiting requested review from sweggersen

1 more reviewer

@kelset kelset kelset approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @kelset