Skip to content

Fix Tooltip on Text not showing up #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

A client was reporting that tooltip wasn't showing up on the text component. This seems to be a simple one line fix.

Changelog

[macOS] [Fixed] - Fix Tooltip on Text not showing up

Test Plan

Checked the tooltip test page that tooltip on shows up.

Screen Shot 2022-01-14 at 10 28 53 PM

@HeyImChris HeyImChris merged commit a45ffbd into microsoft:main Jan 19, 2022
@Saadnajmi Saadnajmi deleted the text-tooltip branch January 19, 2022 07:00
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 19, 2022
@Saadnajmi Saadnajmi mentioned this pull request Jan 19, 2022
4 tasks
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 19, 2022
This was referenced Jan 19, 2022
Saadnajmi added a commit that referenced this pull request Jan 27, 2022
rozele pushed a commit to rozele/react-native-macos that referenced this pull request Oct 11, 2022
Summary:
When building and using C # libraries,
EntryPointNotFoundException thrown from YGInteropSetLogger.

so, I added YOGA_EXPORT on YGInteropSetLogger.

X-link: facebook/yoga#960

Reviewed By: yungsters

Differential Revision: D40027238

Pulled By: yungsters

fbshipit-source-id: 6af584a16e66a31c91374a1bb64434888762e3c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants