Skip to content

cherry-pick animation fix #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

chiuam
Copy link

@chiuam chiuam commented May 5, 2021

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

cherry-pick #763

Changelog

[General] [Fixed] - cherry-pick animation fix

Test Plan

@chiuam chiuam requested a review from tom-un as a code owner May 5, 2021 16:42
Comment on lines +178 to +184
// TODO(macOS ISS#2323203): A bug fix that hasn't been merged to upstream yet.
if (this.__isNative) {
NativeAnimatedAPI.setAnimatedNodeValue(
this.__getNativeTag(),
this._startingValue,
);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Didn't notice but I think we want to stop using ISS numbers and use GitHub issues instead to make em more public. Also there was a TODO [ and // ] END TODO corresponding marker. Sorry I missed that!

@HeyImChris HeyImChris merged commit 0a5ffda into microsoft:0.62-stable May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants