Fix ability to call focus()/blur() on any view #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression from when we upgraded to 0.63 where we could no longer call `focus()` or `blur()` on any `View` (including `Text`). This regression was due to a change that dispatches these as commands (to be compatible with Fabric) instead of directly using `UIManager` to change focus. Only the `TextInput` supported these commands.
HeyImChris
approved these changes
Mar 1, 2021
HeyImChris
pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 3, 2021
This fixes a regression from when we upgraded to 0.63 where we could no longer call `focus()` or `blur()` on any `View` (including `Text`). This regression was due to a change that dispatches these as commands (to be compatible with Fabric) instead of directly using `UIManager` to change focus. Only the `TextInput` supported these commands.
HeyImChris
pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 3, 2021
This fixes a regression from when we upgraded to 0.63 where we could no longer call `focus()` or `blur()` on any `View` (including `Text`). This regression was due to a change that dispatches these as commands (to be compatible with Fabric) instead of directly using `UIManager` to change focus. Only the `TextInput` supported these commands.
HeyImChris
added a commit
that referenced
this pull request
Mar 3, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * Fix ability to call focus()/blur() on any view (#738) This fixes a regression from when we upgraded to 0.63 where we could no longer call `focus()` or `blur()` on any `View` (including `Text`). This regression was due to a change that dispatches these as commands (to be compatible with Fabric) instead of directly using `UIManager` to change focus. Only the `TextInput` supported these commands. * pod install * Fix ability to call focus()/blur() on any view (#738) This fixes a regression from when we upgraded to 0.63 where we could no longer call `focus()` or `blur()` on any `View` (including `Text`). This regression was due to a change that dispatches these as commands (to be compatible with Fabric) instead of directly using `UIManager` to change focus. Only the `TextInput` supported these commands. Co-authored-by: Scott Kyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This fixes a regression from when we upgraded to 0.63 where we could no longer call
focus()orblur()on anyView(includingText). This regression was due to a change that dispatches these as commands (to be compatible with Fabric) instead of directly usingUIManagerto change focus. Only theTextInputsupported these commands.Changelog
[macOS] [Fixed] - Fix ability to call focus()/blur() on any view
Test Plan
Confirmed calling
focus()andblur()onViewandTextcomponents now work again.Microsoft Reviewers: Open in CodeFlow