fix: remove view config mismatches #2642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Aug 12, 2025
packages/react-native/Libraries/Components/ScrollView/ScrollContentViewNativeComponent.js
Show resolved
Hide resolved
tido64
approved these changes
Aug 13, 2025
Saadnajmi
changed the title
Saadnajmi
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Summary: When updating RCTView in #2642, we end up slightly changing the behavior when `didUpdateShadow` is called, causing transparent shadows to crash the app. This breakage occurs because `NSColor colorWithCGColor:` doesn’t accept a `NULL` `CGColorRef`; instead, it raises an exception rather than gracefully returning `nil`. <img height="698" alt="image" src="https://github.com/user-attachments/assets/67413d6e-47e8-47b3-8b29-b9b553cfd19f" /> ## Test Plan: Run RNTester
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Static View configs are a mechanism that React Native uses to ensure that the props and events a native component has match between JS and native. The JS side is statically defined, while the native side is generated based off the view manager (paper only). I think in Fabric, JS is the source of truth completely.
While running RNTester in Fabric, there were a bunch of Redbox warnings warning of static view config mismatches. This might be because we are using views through the interop layer, or there is still validation running that checks against the paper view manager even if we aren't using it. While we have these warnings, let's fix them.
Test Plan:
Launch RNTester on both iOS and macOS from this repo and see no Redboxes warning of mismatches.