Skip to content

fix(presssability): don't set keyboard event handlers on iOS and Android #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 8, 2025
Merged

fix(presssability): don't set keyboard event handlers on iOS and Android #2624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ff6af8
chore: various fixes
Saadnajmi Aug 7, 2025
ead7245
yarn test -u
Saadnajmi Aug 7, 2025
d3eb339
Update packages/react-native/Libraries/Pressability/Pressability.js
Saadnajmi Aug 7, 2025
9769064
fix flow errors
Saadnajmi Aug 8, 2025
82a3d57
Merge branch 'bugs' of github.com:Saadnajmi/react-native-macos into bugs
Saadnajmi Aug 8, 2025
466b770
f
Saadnajmi Aug 8, 2025
b806a30
yarn format
Saadnajmi Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions ...eact-native/Libraries/Components/Pressable/__tests__/__snapshots__/Pressable-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ exports[`<Pressable /> should render as expected: should deep render when mocked
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -69,8 +67,6 @@ exports[`<Pressable /> should render as expected: should deep render when not mo
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -110,8 +106,6 @@ exports[`<Pressable disabled={true} /> should be disabled when disabled is true:
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -151,8 +145,6 @@ exports[`<Pressable disabled={true} /> should be disabled when disabled is true:
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -192,8 +184,6 @@ exports[`<Pressable disabled={true} accessibilityState={{}} /> should be disable
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -233,8 +223,6 @@ exports[`<Pressable disabled={true} accessibilityState={{}} /> should be disable
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -274,8 +262,6 @@ exports[`<Pressable disabled={true} accessibilityState={{checked: true}} /> shou
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -315,8 +301,6 @@ exports[`<Pressable disabled={true} accessibilityState={{checked: true}} /> shou
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -356,8 +340,6 @@ exports[`<Pressable disabled={true} accessibilityState={{disabled: false}} /> sh
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -397,8 +379,6 @@ exports[`<Pressable disabled={true} accessibilityState={{disabled: false}} /> sh
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down
12 changes: 0 additions & 12 deletions ...ve/Libraries/Components/Touchable/__tests__/__snapshots__/TouchableHighlight-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ exports[`TouchableHighlight renders correctly 1`] = `
enableFocusRing={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -51,8 +49,6 @@ exports[`TouchableHighlight with disabled state should be disabled when disabled
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -84,8 +80,6 @@ exports[`TouchableHighlight with disabled state should be disabled when disabled
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -117,8 +111,6 @@ exports[`TouchableHighlight with disabled state should disable button when acces
enableFocusRing={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -151,8 +143,6 @@ exports[`TouchableHighlight with disabled state should keep accessibilityState w
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -184,8 +174,6 @@ exports[`TouchableHighlight with disabled state should overwrite accessibilitySt
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down
14 changes: 0 additions & 14 deletions ...braries/Components/Touchable/__tests__/__snapshots__/TouchableNativeFeedback-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ exports[`<TouchableNativeFeedback /> should render as expected 1`] = `
accessible={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -55,8 +53,6 @@ exports[`<TouchableNativeFeedback disabled={false} accessibilityState={{disabled
accessible={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -88,8 +84,6 @@ exports[`<TouchableNativeFeedback disabled={true} accessibilityState={{}}> shoul
accessible={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -121,8 +115,6 @@ exports[`<TouchableNativeFeedback disabled={true} accessibilityState={{checked:
accessible={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -154,8 +146,6 @@ exports[`<TouchableNativeFeedback disabled={true} accessibilityState={{disabled:
accessible={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -187,8 +177,6 @@ exports[`<TouchableNativeFeedback disabled={true}> should be disabled when disab
accessible={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -220,8 +208,6 @@ exports[`TouchableWithoutFeedback renders correctly 1`] = `
accessible={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down
6 changes: 0 additions & 6 deletions ...tive/Libraries/Components/Touchable/__tests__/__snapshots__/TouchableOpacity-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ exports[`TouchableOpacity renders correctly 1`] = `
enableFocusRing={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -70,8 +68,6 @@ exports[`TouchableOpacity renders in disabled state when a disabled prop is pass
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -115,8 +111,6 @@ exports[`TouchableOpacity renders in disabled state when a key disabled in acces
enableFocusRing={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down
12 changes: 0 additions & 12 deletions ...raries/Components/Touchable/__tests__/__snapshots__/TouchableWithoutFeedback-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ exports[`TouchableWithoutFeedback renders correctly 1`] = `
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -45,8 +43,6 @@ exports[`TouchableWithoutFeedback with disabled state should be disabled when di
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand All @@ -72,8 +68,6 @@ exports[`TouchableWithoutFeedback with disabled state should be disabled when di
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand All @@ -99,8 +93,6 @@ exports[`TouchableWithoutFeedback with disabled state should disable button when
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand All @@ -126,8 +118,6 @@ exports[`TouchableWithoutFeedback with disabled state should keep accessibilityS
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand All @@ -153,8 +143,6 @@ exports[`TouchableWithoutFeedback with disabled state should overwrite accessibi
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down
18 changes: 0 additions & 18 deletions packages/react-native/Libraries/Components/__tests__/__snapshots__/Button-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ exports[`<Button /> should be disabled and it should set accessibilityState to d
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -96,8 +94,6 @@ exports[`<Button /> should be disabled when disabled is empty and accessibilityS
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -166,8 +162,6 @@ exports[`<Button /> should be disabled when disabled={true} and accessibilitySta
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -237,8 +231,6 @@ exports[`<Button /> should be set importantForAccessibility={no-hide-descendants
focusable={false}
importantForAccessibility="no-hide-descendants"
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -303,8 +295,6 @@ exports[`<Button /> should be set importantForAccessibility={no-hide-descendants
focusable={false}
importantForAccessibility="no-hide-descendants"
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -368,8 +358,6 @@ exports[`<Button /> should not be disabled when disabled={false} and accessibili
enableFocusRing={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -434,8 +422,6 @@ exports[`<Button /> should not be disabled when disabled={false} and accessibili
enableFocusRing={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -500,8 +486,6 @@ exports[`<Button /> should overwrite accessibilityState with value of disabled p
enableFocusRing={false}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down Expand Up @@ -570,8 +554,6 @@ exports[`<Button /> should render as expected 1`] = `
enableFocusRing={true}
focusable={false}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down
2 changes: 0 additions & 2 deletions ...ative/Libraries/LogBox/UI/__tests__/__snapshots__/LogBoxInspectorStackFrames-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ exports[`LogBoxInspectorStackFrames should render stack frames with 1 frame coll
enableFocusRing={true}
focusable={true}
onClick={[Function]}
onKeyDown={[Function]}
onKeyUp={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
Expand Down
Loading
Loading