feat: Implement RCTPausedInDebuggerOverlayController #2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Jul 29, 2025
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
commented
Jul 29, 2025
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
commented
Jul 29, 2025
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
commented
Jul 29, 2025
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Show resolved
Hide resolved
tido64
reviewed
Jul 29, 2025
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
commented
Jul 29, 2025
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
changed the title
This was referenced Jul 30, 2025
tido64
reviewed
Jul 30, 2025
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
packages/react-native/React/DevSupport/RCTPausedInDebuggerOverlayController.mm
Outdated
Show resolved
Hide resolved
tido64
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With Hermes and React Native Devtools, pausing the JS debugger presents an overlay over your app, with a "play" button to unpause. I had this ifdefed out during a merge, let's go back and fully implement it.
The overlay is presented as a sheet, like the other floating UI (DevLoadingView, log box, etc)
Test Plan: