chore: update to nx 21 #2560
Merged
chore: update to nx 21 #2560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
force-pushed
the
nx-release-21
branch
6 times, most recently
from
aadec46 to
31c1f4a
Compare
Saadnajmi
changed the title
This was referenced Jul 23, 2025
JasonVMo
approved these changes
Jul 25, 2025
This was referenced Jul 26, 2025
Saadnajmi
added a commit
that referenced
this pull request
Aug 1, 2025
## Summary: With #2560 and followup changes, we call `yarn npm publish` directly instead of `nx release publish` (Which indirectly used npm publish). Yarn's NPM publish command grabs its auth token from `.yarnrc.yml`, not `.npmrc`. Let's update our CI steps that set this. ## Test Plan: Tested that I can call `yarn config set / unset` to set and unset these values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR does several things at once, all in order to improve release flow.
@react-native-macto@react-native-macos(Turns out @dannyvv had ownership of it, and transferred it so our bot can use it 😄)That last one comes with a bunch of changes, as NX 21 comes with a revamped implementation of
nx release:and@react-native-macos/virtualized-listswill always have the same version, and git tags / changelings are all centralized on the react-native-macos version, and followv*..`nx-release-versionfrom being a generator to a version action. This is a new thing with Nx 21's release flow. It behaves the same.workspace:*for just react-native-macos's dependency on virtualized lists.Between simplifying the graph with the "fixed" project relationship, preserving the local dependency protocols, and maybe some logic update to ns release's bump algorithm,
nx releasenow does what I want it to and only bumps react-native-macos and virtualized-lists, instead of also bumping private packages like rn-tester, and @react-native/oss-library-example. This unblocks a persistent bug I had on the stable branches where releases would fail after version bump.Test Plan:
nx release --dry-runseems to do what I want it to.