ci(0.78): Add docs and CI checks for RN peer dependency #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Jul 14, 2025
|
|
||
| ## Hermes Compatibility (0.74 and above) | ||
|
|
||
| *Note: This is only applicable if Hermes is enabled via the `USE_HERMES=1` environment variable when running `pod install`.* |
There was a problem hiding this comment.
Speaking of.. can we find what version of RN set Hermes as the default and align to that now?
There was a problem hiding this comment.
I did this in #2538 when I added a peer dependency to package.json. Or are you referring to something else?
There was a problem hiding this comment.
I'm referring to setting Hermes as the default so that we don't need to do USE_HERMES=1 pod install. That's how RN Core has it
| @@ -34,3 +34,21 @@ stages: | |||
| # jobs: | |||
| # - template: /.ado/jobs/test-react-native-macos-init.yml@self | |||
| # - template: /.ado/jobs/react-native-test-app-integration.yml@self | |||
|
|
|||
| - stage: Validate_Peer_Dependency | |||
| displayName: 'Validate Peer Dependency' | |||
There was a problem hiding this comment.
Can we move to GitHub Actions?
|
Superseded by #2582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This enforces and explains the existence of a peer dependency on RNCore for Hermes builds.
Test Plan:
The added CI should pass.