feat: Use peerDependencies to get Hermes version on stable branches #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amgleitman
changed the title
Saadnajmi
reviewed
Jul 1, 2025
Saadnajmi
reviewed
Jul 1, 2025
Saadnajmi
reviewed
Jul 1, 2025
Saadnajmi
approved these changes
Jul 1, 2025
Saadnajmi
changed the title
Saadnajmi
approved these changes
Jul 1, 2025
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Jul 1, 2025
…icrosoft#2531) This is a follow-up to microsoft#2524 where we expect the RNCore version to be explicitly specified as a peer dependency in our stable branches. branch for cherry-picking into other branches. If CIs pass, we're good. This shouldn't do anything on the main branch anyway, since we don't run through any of the peer dependency logic. Either way, a quick run of RNTester validates that we're still getting our Hermes version via the same `git merge-base` approach. --------- Co-authored-by: Adam Gleitman <[email protected]>
Saadnajmi
pushed a commit
that referenced
this pull request
Jul 2, 2025
## Summary: Discovered when cherry-picking #2531 into #2530. I didn't catch it before because we don't actually run through this part on the main branch. ## Test Plan: No effects on main branch, but #2530 CIs should succeed now. Co-authored-by: Adam Gleitman <[email protected]>
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Jul 2, 2025
…icrosoft#2531) ## Summary: This is a follow-up to microsoft#2524 where we expect the RNCore version to be explicitly specified as a peer dependency in our stable branches. microsoft#2530 brings this in for 0.74-stable; this brings it into the main branch for cherry-picking into other branches. ## Test Plan: If CIs pass, we're good. This shouldn't do anything on the main branch anyway, since we don't run through any of the peer dependency logic. Either way, a quick run of RNTester validates that we're still getting our Hermes version via the same `git merge-base` approach. --------- Co-authored-by: Adam Gleitman <[email protected]>
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Jul 2, 2025
## Summary: Discovered when cherry-picking microsoft#2531 into microsoft#2530. I didn't catch it before because we don't actually run through this part on the main branch. ## Test Plan: No effects on main branch, but microsoft#2530 CIs should succeed now. Co-authored-by: Adam Gleitman <[email protected]>
amgleitman
added a commit
that referenced
this pull request
Jul 2, 2025
## Summary: This is a cherry-pick of #2524 with some more reliable logic for stable branches. The latter will be brought into the main branch in #2531. ## Test Plan: CIs should pass. --------- Co-authored-by: Adam Gleitman <[email protected]>
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Jul 2, 2025
This is a cherry-pick of microsoft#2524 with some more reliable logic for stable branches. The latter will be brought into the main branch in microsoft#2531. CIs should pass. --------- Co-authored-by: Adam Gleitman <[email protected]>
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Jul 2, 2025
This is a cherry-pick of microsoft#2524 with some more reliable logic for stable branches. The latter will be brought into the main branch in microsoft#2531. CIs should pass. --------- Co-authored-by: Adam Gleitman <[email protected]>
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Jul 2, 2025
This is a cherry-pick of microsoft#2524 with some more reliable logic for stable branches. The latter will be brought into the main branch in microsoft#2531. CIs should pass. --------- Co-authored-by: Adam Gleitman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a follow-up to #2524 where we expect the RNCore version to be explicitly specified as a peer dependency in our stable branches.
#2530 brings this in for 0.74-stable; this brings it into the main branch for cherry-picking into other branches.
Test Plan:
If CIs pass, we're good.
This shouldn't do anything on the main branch anyway, since we don't run through any of the peer dependency logic. Either way, a quick run of RNTester validates that we're still getting our Hermes version via the same
git merge-baseapproach.