ci: mark unforked monorepo packages as private #2483
Merged
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It's not clear (both to humans and to build tools like
nx) that the only packages we fork from the React Native monorepo upstream are'react-native' --> 'react-native-macos'and'@react-native/virtualized-lists' --> '@react-native-mac/virtualized-lists'. The rest of the packages should essentially only ever be used in local development, while the published packagereact-native-macosuses the upstream versions of these packages. We can solve this by marking the packages as private.Test Plan:
IIRC, this caused some build failure last time I tried this.. let's see how CI reacts to this change. Further testing with
nx releaseshould be done locally to make sure the nx build graph stops marking the unforked monoreppo packages as dependencies.