ci: update lock file through nx.json flag instead
#2476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 791012b.
JunielKatarn
approved these changes
Apr 17, 2025
Saadnajmi
added a commit
that referenced
this pull request
Apr 17, 2025
Backport of #2476 to 0.78-stable
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Apr 18, 2025
…2477) Backport of microsoft#2476 to 0.78-stable
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Apr 18, 2025
…2477) Backport of microsoft#2476 to 0.78-stable
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Apr 18, 2025
…2477) Backport of microsoft#2476 to 0.78-stable
Saadnajmi
added a commit
that referenced
this pull request
Apr 18, 2025
Backport of #2476 to 0.78-stable
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This reverts commit 791012b.
We had some custom logic to update the lock file after the "version" step of release happened. Turns out you can just do that directly through
nx... so let's remove the logic and do it that was instead.Test Plan:
Ran
nx release --skip-publishlocally (and cmd+c'ed it before it committed anything...) to see if the lock would update with the new versions and it did.