Skip to content

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Mar 28, 2025

Summary:

Only publish packages if there are changes to push

Test Plan:

n/a

@tido64 tido64 requested a review from a team as a code owner March 28, 2025 11:13
@tido64 tido64 marked this pull request as draft March 28, 2025 11:14
@Saadnajmi
Copy link
Collaborator

I opened nrwl/nx#30528

If that is resolved, I think we won't need this

Base automatically changed from tido/verify-npm-auth to main March 28, 2025 12:42
@tido64 tido64 force-pushed the tido/disable-publish branch from cb4713c to b918d91 Compare March 28, 2025 12:43
@tido64 tido64 marked this pull request as ready for review March 28, 2025 12:43
@Saadnajmi
Copy link
Collaborator

Couldn't we just gate this on the existence of a version plan too? Or are you thinking ahead for nightlies?

@tido64
Copy link
Member Author

tido64 commented Mar 31, 2025

Couldn't we just gate this on the existence of a version plan too? Or are you thinking ahead for nightlies?

Aren't version plans deleted by the time we get to the nx release publish step?

@Saadnajmi
Copy link
Collaborator

Couldn't we just gate this on the existence of a version plan too? Or are you thinking ahead for nightlies?

Aren't version plans deleted by the time we get to the nx release publish step?

Right. It's part of versioning. Ok nvm. Feel free to merge.

@tido64 tido64 merged commit 1d0c636 into main Mar 31, 2025
12 checks passed
@Saadnajmi Saadnajmi deleted the tido/disable-publish branch March 31, 2025 17:57
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Apr 16, 2025
## Summary:

Only publish packages if there are changes to push

## Test Plan:

n/a
@Saadnajmi Saadnajmi mentioned this pull request Apr 25, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants