forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 149
ci: setup npm authentication for publish #2422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
reviewed
Mar 18, 2025
tido64
approved these changes
Mar 18, 2025
tido64
reviewed
Mar 18, 2025
Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 26, 2025
`nx release` requires a `.npmrc` file. Let's create one with our NPM auth token, and remove it after we finish publishing out of an abundance of caution. Change is already in 0.76-stable and 0.77-stable. For whatever reason, it works on 0.76 and not on 0.77 --------- Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 26, 2025
`nx release` requires a `.npmrc` file. Let's create one with our NPM auth token, and remove it after we finish publishing out of an abundance of caution. Change is already in 0.76-stable and 0.77-stable. For whatever reason, it works on 0.76 and not on 0.77 --------- Co-authored-by: Tommy Nguyen <[email protected]>
This was referenced Mar 26, 2025
tido64
reviewed
Mar 26, 2025
Comment on lines
+46
to
+47
env: | ||
NODE_AUTH_TOKEN: $(npmAuthToken) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step doesn't need the token
Saadnajmi
added a commit
that referenced
this pull request
Mar 26, 2025
## Summary: Backport #2422 , #2432 , and #2434 to 0.76-stable ## Test Plan: CI should pass --------- Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Mar 26, 2025
## Summary: Backport #2422 , #2432 , and #2434 to 0.77-stable ## Test Plan: CI should pass --------- Co-authored-by: Tommy Nguyen <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
nx release
requires a.npmrc
file. Let's create one with our NPM auth token, and remove it after we finish publishing out of an abundance of caution.Test Plan:
Change is already in 0.76-stable and 0.77-stable. For whatever reason, it works on 0.76 and not on 0.77