Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@anpaz
Copy link
Member

@anpaz anpaz commented Jan 23, 2022

With the migration to .net6, the dotnet compiler is reporting an error because the native simulator dll is picked up from two different locations.
These changes consolidate the native simulators in a single folder by explicitly copying them there, and then selects the right folder depending on the platform.

@anpaz anpaz requested a review from swernli January 23, 2022 02:26
@anpaz anpaz changed the base branch from main to feature/dotnet6 January 23, 2022 02:27
@anpaz anpaz changed the title Fix NETSDK1152 error Consolidate native dlls in a single folder to avoid dupe references (fixes NETSDK1152 error) Jan 23, 2022
@anpaz anpaz enabled auto-merge (squash) January 23, 2022 05:10
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anpaz anpaz merged commit b02c66a into feature/dotnet6 Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants