This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Adding ability to provide content type and encoding for Azure blobs #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarzc
reviewed
Dec 3, 2021
cesarzc
approved these changes
Dec 3, 2021
Co-authored-by: César Zaragoza Cortés <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StorageHelperclasses for theAzure.Clientpackage does not provide a way for clients to specify the content type of the payload and/or when the payload is compressed, specify its encoding asgzip.This is going to be problematic soon as there are plans on the service to start enforcing that both of these settings are correctly set on the blob and be smarter about a Job's payload.
With these changes, a client can now provide the Job's payload content type and to upload it compress, in which case the encoding will be correctly set automatically.