This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Update target package intrinsic names #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the custom instruction names set by the `TargetInstruction` attribute in the Type1, Type2, and Type3 target packages so that they match the naming conventions in the QIR spec. This will avoid unnecessary duplication of instructions, such as `__quantum__qis__x__body` vs `__quantum__qis__x`.
Collaborator
Author
|
@troelsfr This is the PR I mentioned, but I can't seem to add you as a reviewer for some reason. |
|
Thanks. Will have a look tomorrow |
|
I cannot approve this, since I am not a reviewer, but I like the naming updating. |
kuzminrobin
approved these changes
Aug 17, 2021
swernli
added a commit
to microsoft/qsharp-compiler
that referenced
this pull request
Aug 17, 2021
This switches to a newer QDK beta package that has name fixes in the QIR generation for target packages (see microsoft/qsharp-runtime#789). It includes the corresponding updates to the README.md and .ll files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the custom instruction names set by the
TargetInstructionattribute in the Type1, Type2, and Type3 target packages so that they match the naming conventions in the QIR spec. This will avoid unnecessary duplication of instructions, such as__quantum__qis__x__bodyvs__quantum__qis__x.