Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@bamarsha
Copy link
Contributor

Addresses issues brought up in #884.

In some cases, I replaced a catch-all match case with every individual expression kind to make the match exhaustive, which should prevent these matches from being missed when new expression kinds are added in the future.

@bamarsha bamarsha requested review from bettinaheim and swernli April 12, 2021 21:28
@bamarsha bamarsha mentioned this pull request Apr 12, 2021
9 tasks
Copy link
Contributor

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@bamarsha bamarsha merged commit 11a0eed into feature/qep2 Apr 19, 2021
@bamarsha bamarsha deleted the samarsha/sized-array-updates branch April 19, 2021 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants