This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Update use of deprecated range field in UserDefinedType and QsTypeParameter #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Annoyingly, I think the build failures for QIR in this PR are a result of out of sync commits in the e2e pipeline. It's completely unrelated to the changes here. I'll investigate and see if I can get that unblocked here. |
Contributor
Author
|
@swernli I think it should already be fixed since I merged main into feature/qep2 in runtime, but I haven't re-run the builds here. |
bettinaheim
approved these changes
Apr 9, 2021
bamarsha
pushed a commit
to microsoft/qsharp-runtime
that referenced
this pull request
Apr 9, 2021
bamarsha
added a commit
to microsoft/qsharp-runtime
that referenced
this pull request
Apr 9, 2021
Update C# generation tests for microsoft/qsharp-compiler#952
bamarsha
added a commit
to microsoft/qsharp-runtime
that referenced
this pull request
Apr 22, 2021
* Add C# gen for sized array * Implement QArray.Repeat * Add more array tests * Add doc comments * More efficient array creation * Remove TODO, leave exception type untested * Formatting * Update packages * Add tests for ref counts in array-of-arrays * Capture value expression * Undo QscVerbosity * Clean up QArrayInner.Extend * Increment ref count N times * Add comment about exception type * Update packages * Fix partial application code gen test * Update SDK package * Update Microsoft.Quantum.CSharpGeneration.fsproj * Update Microsoft.Quantum.CSharpGeneration.fsproj * Update C# generation tests for microsoft/qsharp-compiler#952 * Update global.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #917 to update usages of now-deprecated
UserDefinedType.RangeandQsTypeParameter.Range:TypeIdRangefield toQsAttributeDeclaration.TypeTransformationBase.OnTypevirtual so thatIdentifierReferenceshas access to both the UDT record andResolvedType.Rangeat the same time.