This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Remove call to initialize LLVM target #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GenerationContext` constructor included a call to Register the current plaform as the target for LLVM, which it turns out is unnecessary for generating target agnostic IR like we do. Further, this reduces the surface are of APIs that we utilize from LLVM, making it easy to identify the required libraries for QIR generation.
idavis
approved these changes
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenerationContextconstructor included a call to Register the current plaform as the target for LLVM, which it turns out is unnecessary for generating target agnostic IR like we do. Further, this reduces the surface are of APIs that we utilize from LLVM, making it easy to identify the required libraries for QIR generation.