This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Prevent Classical Conditions from being Lifted #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
suggested changes
Aug 11, 2021
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
Blocking this until the question is answered and we have sufficient confidence that the fix is correct.
swernli
approved these changes
Aug 12, 2021
Contributor
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
The extra test cases are great, thanks for including those!
bettinaheim
approved these changes
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents classical conditions (those that don't compare Result type expressions) from being lifted. Adds unit tests.
Addresses #768.