This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix type range used when resolving type parameters #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1087.
This is a bit subtle... Basically, when resolving a type parameter, the original code preferred the range of the type that the type parameter pointed to. This is not correct for the example in #1087, because that type range comes from the previous line that declared the variable
carry.In this PR, it now prefers the range of the original type before resolution, whose range corresponds to the reference to
carryon the line with the call toMessage.Since there are no tests for diagnostic ranges, it's hard to say if this won't break any other diagnostics, but I can't think of any examples where this is incorrect...