test: fix watch flake #720
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Nov 20, 2025
tests/watch.spec.ts
Outdated
| ]); | ||
| }); | ||
|
|
||
| // some of our functionality depends on FS events being processed in separate batches |
Contributor
There was a problem hiding this comment.
This comment suggests that we have a bug in the extension itself, not in the test. Could you please make this more specific?
Member
Author
There was a problem hiding this comment.
the key thing is that we need listTests to succeed before kicking off the second file change, otherwise test runner won't know that the changed file is a test. I updated my diff, the previous one was a brain fart
dgozman
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[default-reuse] › tests\watch.spec.ts:593:5 › watching all tests should also execute newly added filesis flaky on windows bots. Here's the fix, apparently our code depends on file changes arriving in separate batches.