Skip to content

chore: validate dictionary keys #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020
Merged

chore: validate dictionary keys #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9481,7 +9481,7 @@
"name": "string",
"properties": {}
},
"comment": "URL of the resource if available.",
"comment": "Optional URL of the resource if available.",
"returnComment": "",
"required": false,
"templates": []
Expand All @@ -9493,7 +9493,7 @@
"name": "number",
"properties": {}
},
"comment": "0-based line number in the resource if available.",
"comment": "Optional 0-based line number in the resource if available.",
"returnComment": "",
"required": false,
"templates": []
Expand All @@ -9505,7 +9505,7 @@
"name": "number",
"properties": {}
},
"comment": "0-based column number in the resource if available.",
"comment": "Optional 0-based column number in the resource if available.",
"returnComment": "",
"required": false,
"templates": []
Expand Down Expand Up @@ -9703,7 +9703,7 @@
"name": "string",
"properties": {}
},
"comment": "Path where the download should be saved. The directory structure MUST exist as `saveAs` will not create it.",
"comment": "Path where the download should be saved.",
"returnComment": "",
"required": true,
"templates": []
Expand Down Expand Up @@ -10632,7 +10632,7 @@
"kind": "method",
"name": "headers",
"type": {
"name": "Object",
"name": "Object<string, string>",
"properties": {}
},
"comment": "",
Expand Down Expand Up @@ -12216,7 +12216,7 @@
"kind": "property",
"name": "viewport",
"type": {
"name": "null|Object",
"name": "?Object",
"properties": {
"width": {
"kind": "property",
Expand Down Expand Up @@ -12358,7 +12358,7 @@
"name": "number",
"properties": {}
},
"comment": "Non-negative accuracy value. Defaults to `0`.",
"comment": "Optional non-negative accuracy value. Defaults to `0`.",
"returnComment": "",
"required": false,
"templates": []
Expand Down
6 changes: 3 additions & 3 deletions playwright/accessibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from typing import Any, Dict, Optional
from typing import Dict, Optional

from playwright.connection import Channel
from playwright.element_handle import ElementHandle
from playwright.helper import locals_to_params


def _ax_node_from_protocol(axNode: Dict[str, Any]) -> Dict[str, Any]:
def _ax_node_from_protocol(axNode: Dict) -> Dict:
result = {**axNode}
if "valueNumber" in axNode:
result["value"] = axNode["valueNumber"]
Expand Down Expand Up @@ -60,7 +60,7 @@ def __init__(self, channel: Channel) -> None:

async def snapshot(
self, interestingOnly: bool = None, root: ElementHandle = None
) -> Optional[Dict[str, Any]]:
) -> Optional[Dict]:
params = locals_to_params(locals())
if root:
params["root"] = root._channel
Expand Down
Loading