Skip to content

Conversation

roberfi
Copy link
Contributor

@roberfi roberfi commented Jul 3, 2025

From playwright version 1.52 to version 1.53, the failure output has changed.

From this:

============================= test session starts ==============================
platform linux -- Python 3.13.2, pytest-8.4.1, pluggy-1.6.0
rootdir: /tmp/pytest-of-robertofernandez/pytest-22/test_is_able_to_set_expect_timeout_via_conftest0
configfile: pytest.ini
plugins: playwright-0.1.dev144+gdc15f33.d20250703, forked-1.6.0, xdist-2.5.0, base-url-2.1.0, asyncio-1.0.0, cov-3.0.0
asyncio: mode=Mode.STRICT, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 1 item

test_is_able_to_set_expect_timeout_via_conftest.py F                     [100%]

=================================== FAILURES ===================================
_________________________ test_small_timeout[chromium] _________________________

page = <Page url='data:text/html,'>

    def test_small_timeout(page):
        page.goto("data:text/html,")
>       expect(page.locator("#A")).to_be_visible()
E       AssertionError: Locator expected to be visible
E       Actual value: <element(s) not found> 
E       Call log:
E         - LocatorAssertions.to_be_visible with timeout 1111ms
E         - waiting for locator("#A")

test_is_able_to_set_expect_timeout_via_conftest.py:5: AssertionError
=========================== short test summary info ============================
FAILED test_is_able_to_set_expect_timeout_via_conftest.py::test_small_timeout[chromium]
============================== 1 failed in 1.95s ===============================

To this:

============================= test session starts ==============================
platform linux -- Python 3.13.2, pytest-8.4.1, pluggy-1.6.0
rootdir: /tmp/pytest-of-robertofernandez/pytest-24/test_is_able_to_set_expect_timeout_via_conftest0
configfile: pytest.ini
plugins: playwright-0.1.dev144+gdc15f33.d20250703, forked-1.6.0, xdist-2.5.0, base-url-2.1.0, asyncio-1.0.0, cov-3.0.0
asyncio: mode=Mode.STRICT, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 1 item

test_is_able_to_set_expect_timeout_via_conftest.py F                     [100%]

=================================== FAILURES ===================================
_________________________ test_small_timeout[chromium] _________________________

page = <Page url='data:text/html,'>

    def test_small_timeout(page):
        page.goto("data:text/html,")
>       expect(page.locator("#A")).to_be_visible()
E       AssertionError: Locator expected to be visible
E       Actual value: <element(s) not found> 
E       Call log:
E         - Expect "to_be_visible" with timeout 1111ms
E         - waiting for locator("#A")

test_is_able_to_set_expect_timeout_via_conftest.py:5: AssertionError
=========================== short test summary info ============================
FAILED test_is_able_to_set_expect_timeout_via_conftest.py::test_small_timeout[chromium]
============================== 1 failed in 1.89s ===============================

So, expected text in test_is_able_to_set_expect_timeout_via_conftest has been changed accordingly.

@roberfi
Copy link
Contributor Author

roberfi commented Jul 3, 2025

@microsoft-github-policy-service agree company="Checkmk GmbH"

@mxschmitt mxschmitt merged commit f667863 into microsoft:main Jul 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants