Skip to content

Conversation

@joshimai
Copy link
Contributor

Description

Change the CI helm chart to reference the new image name https://pcccr.azurecr.io/private/planetary-computer-apis/stac and tiler

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Documentation has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@mmcfarland
Copy link
Member

Looks good! I realized that since we are pulling from a new ACR, we'll need to update the permissions on the cluster. Previously, we were granting pull permissions for a test ACR, but we have been actually pulling from MCR. In that case, I think we can just switch the unused ACR to pcccr and apply the role to it:

diff --git a/deployment/terraform/staging/main.tf b/deployment/terraform/staging/main.tf
index 3351718..a2f8f79 100644
--- a/deployment/terraform/staging/main.tf
+++ b/deployment/terraform/staging/main.tf
@@ -9,6 +9,8 @@ module "resources" {
   cluster_cert_issuer = "letsencrypt"
   cluster_cert_server = "https://acme-v02.api.letsencrypt.org/directory"
 
+  pc_test_resources_acr = "pcccr"
+
   aks_node_count      = 2
   stac_replica_count  = 2
   tiler_replica_count = 2

(see acr.tf)

@joshimai joshimai merged commit b621366 into main Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants