-
Notifications
You must be signed in to change notification settings - Fork 31
Use conda for tiler dependencies, support LERC rasters #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
284754c
Install rasterio & dependencies from conda
fa9b5fb
remove duplicate FROM
414efd2
fixup
263ef5e
Merge remote-tracking branch 'origin/main' into tom/fix/rasterio-conda
mmcfarland adb3128
Set ownership of module directories
mmcfarland 2b62d7c
Changelog
mmcfarland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| FROM pc-apis-tiler | ||
|
|
||
| COPY requirements-dev.txt requirements-dev.txt | ||
| RUN pip install -r requirements-dev.txt | ||
| ARG MAMBA_DOCKERFILE_ACTIVATE=1 | ||
|
|
||
| RUN pip install -e ./pccommon -e ./pctiler | ||
| COPY --chown=$MAMBA_USER:$MAMBA_USER requirements-dev.txt requirements-dev.txt | ||
|
|
||
| RUN python3 -m pip install -r requirements-dev.txt | ||
| RUN python3 -m pip install -e ./pccommon -e ./pctiler | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: base | ||
| channels: | ||
| - conda-forge | ||
| dependencies: | ||
| - python=3.9.16 | ||
| - pystac==1.7.1 | ||
| - jinja2==3.0.3 | ||
| - rasterio==1.3.6 | ||
| - pyproj==3.4.1 | ||
| - planetary-computer==0.4.9 | ||
| - geojson-pydantic==0.4.2 | ||
| # colormap dependencies | ||
| - matplotlib==3.4.3 | ||
| - git | ||
| - pip | ||
| - pip: | ||
| - "titiler.core==0.10.2" | ||
| - "titiler.mosaic==0.10.2" | ||
|
|
||
| - # titiler-pgstac | ||
| - "psycopg[binary,pool]" | ||
| - "titiler.pgstac==0.2.2" | ||
|
|
||
| # - "importlib_resources>=1.1.0;python_version<'3.9'" | ||
| # - "pccommon" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that these lines are slightly risky, in that something in pip-land could decide to (re-)install that something that we expect to get from conda (like rasterio).
I manually verified that things were working as expected (that pip wasn't installing rasterio) but things might change in the future, and we wouldn't necessarily know until stuff breaks.