This repository was archived by the owner on May 7, 2024. It is now read-only.
Fix for Azure SQL Data Warehouse #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pensivebrian, |
Codecov Report
@@ Coverage Diff @@
## dev #125 +/- ##
=======================================
Coverage 83.26% 83.26%
=======================================
Files 15 15
Lines 1046 1046
=======================================
Hits 871 871
Misses 175 175
Continue to review full report at Codecov.
|
MrMeemus
approved these changes
Aug 1, 2017
This was referenced Aug 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the mssql-scripter version to a18 and the sqltoolsservice version that contains the fix for scripting Azure SQL Data Warehouse. The underlying issue was Azure SQL Data Warehouse does not support the
select @@servername, so we now useselect SERVERPROPERTY('ServerName')for Azure SQL Data Warehouse.