Skip to content

Fix find_link_library in the event the linker flag check fails. #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WildCard65
Copy link

This small pull request fixes the issue #1113 by doing 2 things:

  1. Actually pass the library name being searched for to find_library
  2. Use unique variables when invoking find_library in order to avoid any shenanigans older CMake versions may pull (unlikely, but better to be safe than sorry).

@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 20:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the find_link_library CMake function where the library name parameter was not being properly passed to find_library, and improves variable naming to avoid potential conflicts across multiple invocations.

  • Corrects the find_library call to actually use the libname parameter instead of treating it as a literal string
  • Updates variable names to be unique per library to prevent potential CMake variable collision issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant