Improve ResolveMainClassHandler.resolveMainClassUnderPaths #596
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the ResolveMainClassHandler.resolveMainClassUnderPaths method to provide more targeted main class resolution by filtering projects based on provided paths instead of searching all Java projects.
- Adds conditional logic to filter Java projects when specific paths are provided
- Removes
REFERENCED_PROJECTSflag from search scope to focus only on source files - Imports
JavaCoreutility for creating IJavaProject instances
| projects = ProjectUtils.getJavaProjects(); | ||
| } else { | ||
| projects = Stream.of(ProjectUtils.getAllProjects()) | ||
| .filter(p -> ProjectUtils.isJavaProject(p) && ResourceUtils.isContainedIn(p.getLocation(), parentPaths)) |
There was a problem hiding this comment.
The condition ResourceUtils.isContainedIn(p.getLocation(), parentPaths) may cause issues if p.getLocation() returns null. Project locations can be null for certain project types or when projects are not properly initialized.
| .filter(p -> ProjectUtils.isJavaProject(p) && ResourceUtils.isContainedIn(p.getLocation(), parentPaths)) | |
| .filter(p -> ProjectUtils.isJavaProject(p) && p.getLocation() != null && ResourceUtils.isContainedIn(p.getLocation(), parentPaths)) |
Copilot uses AI. Check for mistakes.
| projects = Stream.of(ProjectUtils.getAllProjects()) | ||
| .filter(p -> ProjectUtils.isJavaProject(p) && ResourceUtils.isContainedIn(p.getLocation(), parentPaths)) | ||
| .map(p -> JavaCore.create(p)) | ||
| .filter(p -> p != null && p.exists()) |
There was a problem hiding this comment.
The null check for p is redundant since JavaCore.create() never returns null - it returns a handle that may or may not exist. Consider removing the null check and only keeping the exists() check.
| .filter(p -> p != null && p.exists()) | |
| .filter(p -> p.exists()) |
Copilot uses AI. Check for mistakes.
Fixes #595